On Wed, 8 Oct 2025 22:11:35 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright
>
> src/hotspot/share/oops/constantPool.cpp line 1626:
>
>> 1624: void ConstantPool::copy_bsm_entries(const constantPoolHandle& from_cp,
>> 1625: const constantPoolHandle& to_cp,
>> 1626: TRAPS) {
>
> Nit: Indent is not right.
These indentations faults have been all over (all my fault of course), thank
you for spotting them.
> src/hotspot/share/oops/constantPool.inline.hpp line 90:
>
>> 88: return
>> resolved_references()->obj_at(cache()->resolved_method_entry_at(index)->resolved_references_index());
>> 89: }
>> 90:
>
> Nit: Is this really needed?
I believe that the style is to have an empty line between the code and the
endif, so this is a style fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2433423167
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2433420483
