On Wed, 29 Oct 2025 11:57:45 GMT, Matthew Donovan <[email protected]> wrote:
>> This PR updates tests that were using MD5 certificates. For most of the
>> tests, I added test cases for TLSv1.2/MD5withRSA and TLSv1.3/SHA256withRSA.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed tests to use SecurityUtils.removeDisabled*Algs methods
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IdentitiesBase.java line
184:
> 182: SSLContext ctx = SSLContext.getInstance(protocol);
> 183:
> 184: if (keyCert != null) {
Why do we check for keyCert being `null`? Do we expect some future tests to
make use of it? BTW, in such case `CertificateBuilder.printCertificate` would
fail first.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27342#discussion_r2479633177
