On Wed, 29 Oct 2025 21:07:51 GMT, Mat Carter <[email protected]> wrote:

>> Add jdk.management.AOTCacheMXBean. The interface provides a single action 
>> that when called will cause any hosted JVM currently recording AOT 
>> information will stop recording. Existing functionality is preserved: when 
>> stopped the JVM will create the required artifacts based on the execution 
>> mode. Conveniently as the application running on the JVM has not stopped (as 
>> was previously the only way to stop recording), the application will resume 
>> execution after the artifacts have been generated.
>> 
>> The interface will return TRUE if a recording was successfully stopped, in 
>> all other cases (not recording etc.) will return FALSE
>> 
>> It follows that invoking the action on a JVM that is recording, twice in 
>> succession, should (baring internal errors) produce the following two 
>> responses:
>> 
>> TRUE
>> FALSE
>> 
>> Passes tier1 on linux (x64) and windows (x64)
>
> Mat Carter has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updated test based on comments

Changes requested by mr (Lead).

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java line 
78:

> 76:        *  specification of the corresponding JVM command-line options, 
> please refer
> 77:        * to https://openjdk.org/jeps/483 and https://openjdk.org/jeps/514.
> 78:        *

Please don't use bare URLs. Change these to

... please refer to JEPs <a href="https://openjdk.org/jeps/483";>483</a> and
<a href="https://openjdk.org/jeps/514";>514</a>.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28010#pullrequestreview-3424599728
PR Review Comment: https://git.openjdk.org/jdk/pull/28010#discussion_r2496294936

Reply via email to