On Mon, 27 Oct 2025 18:08:40 GMT, Chad Rakoczy <[email protected]> wrote:

>>> @chadrako, is PR ready for testing now?
>> 
>> Yes
>
>> @chadrako I think my suggestion was not correct. We should revert back to 
>> your first changes for `@requires`. Original code was correct and only 
>> `serviceability/jvmti/NMethodRelocation/NMethodRelocationTest.java` missed 
>> it.
> 
> Since the tests get run with different GCs anyways I don't think we need to 
> explicitly require the GC that they run with and just have one test config

> FTR, even with this fix, we still see failures: 
> [JDK-8371121](https://bugs.openjdk.org/browse/JDK-8371121), 
> [JDK-8371046](https://bugs.openjdk.org/browse/JDK-8371046), 
> [JDK-8369150](https://bugs.openjdk.org/browse/JDK-8369150). @chadrako It 
> would be great if you could prioritize fixing these remaining issues, as the 
> failures cause quite some noise in our testing. Thanks!

@TobiHartmann I apologize for the noise and appreciate you bringing these to my 
attention. I am prioritizing the fixes and will keep the JBS issues updated 
with my progress.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27659#issuecomment-3505482325

Reply via email to