On Mon, 17 Nov 2025 19:23:52 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8366659: Addressed reviewer's comments.
>
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithObjectMonitorWait/SuspendWithObjectMonitorWait.java
> line 140:
>
>> 138: // launch resumer enter threadLock
>> 139: // <launch returns> while !READY_TO_NOTIFY resumer running
>> 140: // : threadLock.wait(1) wait for notify
>
> The wait(1) call is in the while-loop. Please insert two spaces before the
> `threadlock.wait(1)` call.
Addressed.
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithObjectMonitorWait/SuspendWithObjectMonitorWait.java
> line 235:
>
>> 233: } catch (NumberFormatException nfe) {
>> 234: System.err.println("'" + args[argIndex] +
>> 235: "': invalid test_case value.");
>
> The leading double quote should be lined up with the one on the previous line.
Addressed.
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithObjectMonitorWait/SuspendWithObjectMonitorWait.java
> line 251:
>
>> 249: } catch (NumberFormatException nfe) {
>> 250: System.err.println("'" + args[argIndex] +
>> 251: "': invalid time_max value.");
>
> The leading double quote should be lined up with the one on the previous line.
Addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2537288143
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2537288285
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2537288511
