On Tue, 23 Sep 2025 02:40:48 GMT, David Holmes <[email protected]> wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> >> - addressed review comments > > src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java line > 31: > >> 29: import com.sun.tools.attach.spi.AttachProvider; >> 30: >> 31: import sun.jvmstat.PlatformSupport; > > This is convenient but I'm not sure it is appropriate. Need the > serviceability folk to comment. This looks like an unexpected and undesired dependency. I'll consult with other serviceability guys to find out what is better here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25824#discussion_r2583491666
