On Mon, 15 Dec 2025 06:25:43 GMT, SendaoYan <[email protected]> wrote:
>> Hi all, >> >> The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property >> from "jdk.test.docker.retain.image" do not work for some of the docker >> tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only >> works for some of the docker tests, such as >> jdk/internal/platform/docker/TestPidsLimit.java. >> >> This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function >> removeDockerImage instead of before all the fucntion removeDockerImage. This >> will make all the docker tests receive the property >> jdk.test.docker.retain.image. >> >> Change has been verified locally on linux-x64 by run the all touched tests. > > SendaoYan has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Merge branch 'openjdk:master' into jbs8371503 > - Remove extra ident > - 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests Thanks - now it makes sense to me. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28208#pullrequestreview-3576654982
