On Tue, 30 Dec 2025 19:17:01 GMT, Leonid Mesnik <[email protected]> wrote:
>> Chad Rakoczy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Require load and unload events
>> - Revert "Fix NMethodRelocationTest"
>>
>> This reverts commit dae91d8d12820c94c2c412f3e84935072e572595.
>
> test/hotspot/jtreg/serviceability/jvmti/NMethodRelocation/NMethodRelocationTest.java
> line 188:
>
>> 186: WHITE_BOX.deoptimizeAll();
>> 187:
>> 188: while (true) {
>
> It would be better to have some variable that is set in
> 'callbackCompiledMethodUnload' to sync exit.
> I think that it is more reliable then using stdout for this (even with
> flushing).
> However, it might be fixed later, if we find any issues with current version.
I agree I don't think we should rely on stdout. I updated the test so all the
event checking happens in the agent, and I kept some of the logging for
debugging.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28683#discussion_r2654280547
