On Tue, 20 Jan 2026 18:42:54 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8366659: Fixed whitespace.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1933:
>
>> 1931: // Post monitor waited event. Note that this is past-tense, we are
>> done waiting.
>> 1932: // A thread which should post monitor_waited event is never in
>> TS_ENTER state.
>> 1933: if (JvmtiExport::should_post_monitor_waited()) {
>
> Is it worth asserting that `node.TState != ObjectWaiter::TS_ENTER` inside the
> if-statement?
I think we will have to add it as a branch condition since the event could have
been enabled after notification.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2710952492
