On Thu, 12 Mar 2026 15:28:15 GMT, Roman Kennke <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 65 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - David: reduce diff in ObjectCountEventVerifier.java >> - David: minimize change in GetObjectSizeIntrinsicsTest.java >> - David: minimize diffs in TestZGCWithCDS.java >> - David: minimize diffs for >> runtime/ErrorHandling/TestVMConfigInHsErrFile.java >> - ... and 55 more: https://git.openjdk.org/jdk/compare/9a26b4af...be3a902b > > src/hotspot/share/memory/metaspace.hpp line 168: > >> 166: >> 167: static bool is_class_space_allocation(MetadataType mdType) { >> 168: return CLASS_SPACE_ONLY(mdType) NOT_CLASS_SPACE(false); > > This is confusing me. Is ClassType the only non-zero MetadataType? Might be > better to write that out as before, otherwise it's a weird implicit > conversion from MetadataType to bool. Actually I think this is a bug because the enum is exactly backwards. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2925523874
