On Fri, 20 Mar 2026 16:34:42 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 69 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - removed CompressedKlassPointers::needs_class_space, since we have now >> INCLUDE_CLASS_SPACE >> - Feedback Roman >> - Merge Master >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - ... and 59 more: https://git.openjdk.org/jdk/compare/f2550e89...35f672c2 > > src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 765: > >> 763: #ifdef ASSERT >> 764: // TraceBytecodes does not use r12 but saves it over the call, so >> don't verify >> 765: // if (!TraceBytecodes) verify_heapbase("call_VM_base: heap base >> corrupted?"); > > Only `if()` was commented before. Now you put `verify_heapbase()` under > comment too. > Even so `verify_heapbase()` is empty on this platform we should not change > this. Hi, @vnkozlov, I am not sure I understand. The full line - including `verify_heapbase` - was commented out previously and remains commented out. Is GitHub's diff viewer acting up again? All I did was to correct the statement in case someone removes the comment to trace things: since UseCompressedClassPointers is now always true, `((UseCompressedOops || UseCompressedClassPointers) && !TraceBytecodes)` becomes `(!TraceByteCodes)` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2973282172
