On Tue, 26 May 2026 16:58:51 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: 1. Add asserts, rem comment 2. Remove
>> can_generate_frame_pop_events from can_generate_interpreter_events
>
> src/hotspot/share/interpreter/interpreterRuntime.cpp line 1077:
>
>> 1075: assert(last_frame.is_interpreted_frame(), "must come from
>> interpreter");
>> 1076:
>> 1077: if (JvmtiExport::can_post_frame_pop() &&
>> JvmtiExport::has_frame_pop_for_top_frame(current)) {
>
> Shouldn't be this guarded by 'INCLUDE_JVMTI' or something similar?
Good question, thanks. We have `INCLUDE_JVMTI` just for
`InterpreterRuntime::member_name_arg_or_null()` but not for other places where
the `JvmtiExport::*` functions are used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3307305622
