On Wed, 6 May 2026 21:00:19 GMT, Kevin Walls <[email protected]> wrote:
>> src/hotspot/share/classfile/dictionary.cpp line 242:
>>
>>> 240:
>>> 241: void Dictionary::print_table_statistics(outputStream* st, const char*
>>> table_name) {
>>> 242: NOT_WINDOWS(static) TableStatistics ts; // Avoid atexit for static
>>> destructor on Windows
>>
>> I think that we can just delete this static, I opened a separate PR for it:
>> https://github.com/openjdk/jdk/pull/31039
>
> Excellent, yes I nearly went that far as well. Surely these are not often
> used, quite niche commands (VM.stringtable, VM.symboltable,
> VM.systemdictionary).
Hi @kevinjwalls ! I looked at this again and the final PR I opened is quite a
bit more complex, changing the mechanism entirely. Good news is that there is
no `static TableStatistics` anymore. Good to know when the merge conflict is
being resolved :-).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3373596874
