On Tue, 2 Jun 2026 04:42:46 GMT, David Holmes <[email protected]> wrote:
>> Please review this test enhancement. >> Implemented the padding-tolerant Unified Logging assertions. >> A bunch of Unified Logging assertions do not account for possible extra >> padding in the `[<tags>]` section. >> >> Changed short-tag UL assertions from rigid `shouldContain(...)` to >> `shouldMatch(...)` with patterns like: >> >> \[class,load *\] ... >> >> >> Covered short categories including `class,load`, `nmt`, `pagesize`, `aot`, >> `jni`, `cds`, and `trimnative`. I left remaining `shouldContain()` hits >> alone where the tag set is long enough - `class,resolve`, `verification`, >> `gc,heap,coops`, etc.). >> >> Also updated a couple of existing rigid `shouldMatch()` UL regexes for the >> same padding issue. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > One suggestion though - change the synopsis to "Make unified logging checks > in tests tolerant of added spaces" (they aren't really "asserts"). @dholmes-ora @iklam The code was updated after your approval. May I have your re-review? ------------- PR Comment: https://git.openjdk.org/jdk/pull/31338#issuecomment-4648110280
