On Wed, 10 Jun 2026 16:37:32 GMT, Vladimir Kozlov <[email protected]> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix setting of CopyAVX3Threshold
>>   
>>   Signed-off-by: Ashutosh Mehra <[email protected]>
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1105:
> 
>> 1103:   // For AMD Processors use XMM/YMM MOVDQU instructions
>> 1104:   // for Object Initialization as default
>> 1105:   if (is_amd()) {
> 
> Do we need this? We are in `amd_config()`.

yes, I think it is needed because `amd_config()` is used for both `is_amd()` 
and `is_hygon()`:


  if (is_amd_family()) {
    amd_config();
  }

and

  static bool is_amd_family()     { return is_amd() || is_hygon(); }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31301#discussion_r3433196115

Reply via email to