On Wed, 8 Jul 2026 07:19:57 GMT, David Simms <[email protected]> wrote:
>> This pull request implements the first >> [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Classes and >> Objects](https://openjdk.org/jeps/401): >> >> - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31121 >> - [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31122 >> - [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard >> library implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31123 >> >> This pull request also includes the implementation of [Strict Field >> Initialization in the JVM (Preview)](https://openjdk.org/jeps/8350458) (yet >> to have been assigned a JEP number). That work was implemented in the same >> code base because JEP 401 depends on strict field initialization. >> >> This is the "*master pull request*" for the initial preview of [JEP >> 401](https://openjdk.org/jeps/401). Comments and review for a change this >> large will not scale well in a single pull request. This pull request serves >> as the vehicle for sign-off and integration into >> [`jdk/master`](https://github.com/openjdk/jdk). **Review comments should be >> directed to the appropriate "*sub-review pull request*" listed above.** >> >>> [!NOTE] >>> The "*sub-review pull requests*" contain the same full set of code changes >>> as this "*master pull request*" to preserve the full implementation >>> context; the language compiler, JVM, and standard library changes are >>> intertwined. The separate pull requests exist only to subdivide the review >>> and related discussion by area. >> >> Any resulting code changes should be made in >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/). >> >> `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly >> [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, >> code changes from `valhalla/lworld` will be propagated to this pull request >> and to all sub-review pull requests. >> >> Ultimately, review sign-off will be recorded on this "*master pull >> request*", and the "*sub-review pull requests*" will be closed without >> integration. >> >> This pull request has a large surface area and frequently conflicts with >> `jdk/master`. Refer to >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest >> state of the project code, keeping in mind that it may lag several days >> behind `jdk/mast... > > David Simms has updated the pull request incrementally with 10 additional > commits since the last revision: > > - Merge remote-tracking branch 'valhalla/lworld' into 8317277 > - 8387703: [lworld] address batch of comments in mainline PR > > Co-authored-by: Tobias Hartmann <[email protected]> > Reviewed-by: thartmann, dlong > - 8387661: [lworld] move generate_return_value_stub() to SharedRuntime > > Reviewed-by: adinn, thartmann > - 8387405: [lworld] is_always_flat_in_array should be always false > > Reviewed-by: thartmann > - 8387686: [lworld] Update the JNI specification version for value types > > Reviewed-by: alanb, dsimms > - 8387726: [lworld] JVMTI/JDWP/JDI docs cleanup > > Reviewed-by: sspitsyn, cjplummer > - 8387673: [lworld] C2: clone() intrinsic does not throw > CloneNotSupportedException for value classes not implementing Cloneable > > Reviewed-by: thartmann > - 8387709: [lworld] Split Valhalla tests from tier1_compiler_3 to avoid task > timeouts > > Reviewed-by: chagedorn > - 8387350: [lworld] ObjectOutputStream.writeObject() doesn't throw > InvalidClassException for Serializable instance with strict init fields > > Reviewed-by: alanb, jpai, thartmann > - 8387030: [lworld] two compiler/valhalla/inlinetypes/TestValueClasses.java > sub-tests fail test3_verifier and test1_verifier > > Reviewed-by: thartmann CDS/AOT changes look reasonable to me. ------------- Marked as reviewed by iklam (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31120#pullrequestreview-4665348049
