On Fri, 10 Jul 2026 07:25:06 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved down AltTempDir in jinfo.md
>
> src/hotspot/os/linux/os_linux.cpp line 1571:
>
>> 1569: } else {
>> 1570: if (!is_writable_directory(AltTempDir)) {
>> 1571: log_warning(os)("Warning: AltTempDir is not an existing or
>> writable directory");
>
> Nit: Should we add this line here as well as at line the 1568: `AltTempDir =
> nullptr;` ?
No, if we are trying to attach from the host to a container, the host may not
have this directory but the container does, so we want the attach to succeed
once it adds /proc/pid/root/AltTempDir and not go back to /tmp. I should add a
comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3559221447
