On Thu, 30 Jul 2026 23:38:40 GMT, David Simms <[email protected]> wrote:

>> This pull request implements the first 
>> [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Objects 
>> (Preview)](https://openjdk.org/jeps/401). This pull request also includes 
>> the implementation of [JEP 539: Strict Field Initialization in the JVM 
>> (Preview)](https://openjdk.org/jeps/539). That work was implemented in the 
>> same code base because JEP 401 depends on strict field initialization.
>> 
>> Sub-reviews, for spreading review debates are here:
>> 
>> - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language 
>> implementation of value objects
>>   - https://github.com/openjdk/jdk/pull/31121
>> - [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM 
>> implementation of value objects
>>   - https://github.com/openjdk/jdk/pull/31122
>> - [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard 
>> library implementation of value objects
>>   - https://github.com/openjdk/jdk/pull/31123
>> 
>> This is the "*master pull request*" for the initial preview of [JEP 
>> 401](https://openjdk.org/jeps/401). Comments and review for a change this 
>> large will not scale well in a single pull request. This pull request serves 
>> as the vehicle for sign-off and integration into 
>> [`jdk/master`](https://github.com/openjdk/jdk). **Review comments should be 
>> directed to the appropriate "*sub-review pull request*" listed above.**
>> 
>> 
>>> [!NOTE]
>>> The "*sub-review pull requests*" contain the same full set of code changes 
>>> as this "*master pull request*" to preserve the full implementation 
>>> context; the language compiler, JVM, and standard library changes are 
>>> intertwined. The separate pull requests exist only to subdivide the review 
>>> and related discussion by area.
>> 
>> Any resulting code changes should be made in 
>> [`valhalla/lworld`](https://github.com/openjdk/valhalla/).
>> 
>> `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly 
>> [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, 
>> code changes from `valhalla/lworld` will be propagated to this pull request 
>> and to all sub-review pull requests.
>> 
>> Ultimately, review sign-off will be recorded on this "*master pull 
>> request*", and the "*sub-review pull requests*" will be closed without 
>> integration.
>> 
>> This pull request has a large surface area and frequently conflicts with 
>> `jdk/master`. Refer to 
>> [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest 
>> state of the project code, keeping in mind that it may lag several days 
>> behind `jdk/master`. Both repositor...
>
> David Simms has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 2934 commits:
> 
>  - Merge remote-tracking branch 'valhalla/lworld' into 8317277
>  - Merge
>  - 8386451: [lworld] things to delete from lworld just before integrating 
> JEP-401
>    
>    Reviewed-by: coleenp, dsimms, liach, lfoltan
>  - Merge
>    
>    Reviewed-by: liach, dsimms
>  - Merge
>    
>    Reviewed-by: dsimms
>  - 8389365: [lworld] Fix ProblemList marker comments and misc cleanups
>    
>    Reviewed-by: fparain, liach
>  - Merge
>    
>    Reviewed-by: dsimms
>  - Merge remote-tracking branch 'valhalla/lworld' into 8317277
>  - 8389322: [lworld] Disable TestNullableInlineTypes::test103() until 
> JDK-8389088 is fixed
>    
>    Reviewed-by: thartmann, dcubed
>  - 8389085: [lworld] C2: assert(field_value != nullptr) failed in 
> PhaseMacroExpand::inline_type_from_mem
>    
>    Reviewed-by: mhaessig, chagedorn
>  - ... and 2924 more: https://git.openjdk.org/jdk/compare/0d4fb556...58712b78

What happens if I do this early:

Just to get it in the right order... if that makes a difference...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31120#issuecomment-5137620575
PR Comment: https://git.openjdk.org/jdk/pull/31120#issuecomment-5137626061

Reply via email to