On Fri, 21 Aug 2026 23:17:03 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix spelling and incorrect logging
>
> test/hotspot/jtreg/vmTestbase/nsk/jdwp/ClassType/SetValues/setvalues001.java
> line 482:
>
>> 480: }
>> 481: }
>> 482: log.display("Verfied using JDWP ClassType.Getvalues that all
>> static fields values have been correctly set");
>
> Nit: Should the line 482 be executed in the success case only?
Fixed.
> test/hotspot/jtreg/vmTestbase/nsk/jdwp/ObjectReference/SetValues/setvalues001.java
> line 187:
>
>> 185: + " " + TESTED_FINAL_CLASS_SIGNATURE);
>> 186: long testedFinalClassID =
>> debugee.getReferenceTypeID(TESTED_FINAL_CLASS_SIGNATURE);
>> 187: log.display(" got tested final classID: " +
>> testedClassID);
>
> Q: Should it be `testedFinalClassID` instead of `testedClassID`?
Fixed.
> test/hotspot/jtreg/vmTestbase/nsk/jdwp/ObjectReference/SetValues/setvalues001.java
> line 568:
>
>> 566: }
>> 567: }
>> 568: log.display("Verfied using JDWP ObjectReference.Getvalues that
>> all fields values have been correctly set");
>
> Nit: Should the line 568 be executed in the success case only?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32029#discussion_r3834595635
PR Review Comment: https://git.openjdk.org/jdk/pull/32029#discussion_r3834595138
PR Review Comment: https://git.openjdk.org/jdk/pull/32029#discussion_r3834596025
