On Wed, 26 Aug 2026 06:17:50 GMT, Shiv Shah <[email protected]> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java
>> line 702:
>>
>>> 700: && elements[i].getMethodName().equals("sleep")) {
>>> 701: return super.checkStackTrace(
>>> 702: Arrays.copyOfRange(elements, i,
>>> elements.length));
>>
>> Nit: A comment would be nice to have before the line 701 to explain why a
>> call to the super.checkStackTrace() is needed. We already found a frame with
>> the sleep() method. What else do we need here?
>> Q: Also, Is it okay to have two methods with the same signature and
>> implementation? Can we avoid this duplication?
>
> The two frameworks sit in separate hierarchies with their own base checks so
> there’s no shared spot for it without new cross package plumbing
Okay, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31357#discussion_r3861238944
