On Thu, 17 Sep 2026 13:56:11 GMT, Dan Heidinga <[email protected]> wrote:
>> [Picking up and finishing off https://github.com/openjdk/jdk/pull/32519 for >> Coleen] >> >> Remove the upcall to addClass during class loading. The comment says it's >> only so GC can keep classes alive while the class loader is alive. We have >> other ways to do that. There were some JVMTI tests in the past that failed >> without this vector but today seems to be only one test. Maybe there's some >> code that has a dependency on this in heap walking. >> Tested tier1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Dan Heidinga has updated the pull request incrementally with one additional > commit since the last revision: > > Renamed test and removed field not present assert src/hotspot/share/prims/jvmti.xml line 3603: > 3601: </constant> > 3602: <constant id="JVMTI_HEAP_REFERENCE_OTHER" num="27"> > 3603: Other reference from an object to another object, or other > heap root reference. Reading the spec again, I think we should also add to the referrer_tag_ptr's description to make it clear how JVMTI_HEAP_REFERENCE_OTHER is handled. I thin this would work: "For JVMTI_HEAP_REFERENCE_OTHER, this parameter can be null or non-null, depending on whether the callback is reporting a heap root reference or a reference from an object." There's also a pre-existing typo in this description where it has "Null if the referrer in not an object". This is directly relevant to the change so I think we can make that "is not an object" at the same time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32890#discussion_r4062795813
