On Mon, 28 Sep 2026 11:45:22 GMT, Johan Sjölen <[email protected]> wrote:

> This patch depends on `LogFileOutput`'s log name having `file=` prepended. I 
> think that depending on this fact is a bug waiting to happen. We should try 
> to find a way of implementing this which allows for better type safety.

Thanks, I've added a virtual `LogOutput::matches_name()` method and overridden 
it in LogFileOutput. This removes the downcast based on the file= prefix.

Could you take another look?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33090#issuecomment-5872795933

Reply via email to