On Mon, 26 Oct 2026 03:37:04 GMT, Dingli Zhang <[email protected]> wrote:
>> Thanks @DingliZhang. >> >> My patch modifies the shared `dwarf.cpp`, which could potentially affect >> existing behavior on amd64/aarch64. Since @YaSuenag suggested handling amd64 >> and aarch64 in a separate issue, I see two possible ways to move forward >> with my patch: >> 1. Add architecture-specific macros to `dwarf.cpp` so that the inclusive PC >> condition applies only to riscv64. >> 2. Wait until the patch that changes amd64/aarch64 to a PC-selection >> mechanism similar to GDB’s is merged, and then merge my patch. >> >> What do you think? > >> What do you think? > > I'd prefer option 2: land the amd64/aarch64 PC-selection fix first, then > rebase this PR on top of it. That avoids introducing a temporary > architecture-specific condition in the shared DWARF parser. @DingliZhang @YaSuenag Would you be willing to sponsor this PR? ------------- PR Comment: https://git.openjdk.org/jdk/pull/33374#issuecomment-6594617611
