On Tue, 10 Nov 2026 16:51:48 GMT, Sergey Nazarkin <[email protected]> wrote:
>> src/hotspot/share/services/heapDumper.cpp line 2914:
>>
>>> 2912: if (!dumper.is_parallel_dump()) {
>>> 2913: DumperSupport::end_of_dump(&writer);
>>> 2914: writer.flush();
>>
>> Shouldn't we check for an error here?
>
> Hi Johan! Thanks for the review. You are right, writer may fail here as well.
Fixed
https://github.com/openjdk/jdk/pull/32733/changes/85000f6659d36f7d96550b217c994486dbf2271b
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32733#discussion_r4527986071