[ 
https://issues.apache.org/activemq/browse/SM-582?page=comments#action_37102 ] 
            
Grant McDonald commented on SM-582:
-----------------------------------

Committed changes.

Adding         
servicemix-components\src\main\java\org\apache\servicemix\components\validation\CountingErrorHandlerFactory.java
Sending        
servicemix-components\src\main\java\org\apache\servicemix\components\validation\MessageAggregatingErrorHandler.java
Adding         
servicemix-components\src\main\java\org\apache\servicemix\components\validation\MessageAggregatingErrorHandlerFactory.java
Adding         
servicemix-components\src\main\java\org\apache\servicemix\components\validation\MessageAwareErrorHandlerFactory.java
Sending        
servicemix-components\src\main\java\org\apache\servicemix\components\validation\ValidateComponent.java
Sending        
servicemix-components\src\test\resources\org\apache\servicemix\components\validation\example.xml
Transmitting file data ......
Committed revision 453155.

> Current ErrorHandler implementation used by ValidateComponent is not thread 
> safe
> --------------------------------------------------------------------------------
>
>                 Key: SM-582
>                 URL: https://issues.apache.org/activemq/browse/SM-582
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-components
>    Affects Versions: incubation
>         Environment: Ubuntu Linux 6.06 LTS, WinXP SP2
>            Reporter: Grant McDonald
>         Assigned To: Grant McDonald
>         Attachments: SM-582.patch
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> Due to the error handler being dependency injected it is a singleton which 
> unfortunately stores state across invocations.  The solution is to use the 
> factory pattern, whereby an ErrorHandlerFactory implementation is created as 
> the singleton which has properties containing the arguments to pass to the 
> ErrorHandler when it is instantiated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to