Hi, Paul
Two points: 1) Don't you check for nulls in any of your request parameters?
Even just one null can hose your SQL string. 2) Try using a
PreparedStatement. Otherwise, fname values like "O'Reilly" will render the
resulting SQL invalid.
Regards,
Noel Lecaros
Paul Foxton wrote:
> thanks John,
>
> yes I tried that too.
>
> I'm thinking I must have an error somewhere else now.
>
> the servlet gets right up to: stmt.executeUpdate(sql);
>
> and throws an exception.
>
> Ho hum, back to the drawing board :)
>
> -----Original Message-----
> From: John Johnson [mailto:[EMAIL PROTECTED]]
> Sent: 04 May 2001 17:47
> To: [EMAIL PROTECTED]
> Subject: Re: SQL string
>
> Hi Paul,
>
> Don't you need single quotes surrounding the values which you are
> inserting??
>
> for example: INSERT INTO table (field1,field2) VALUES
> ('value1','value2')
>
> Cheers,
> -john
>
> Paul Foxton wrote:
> >
> > hopefully a simple one -
> >
> > can anyone tell me if theres anything wrong with this SQL string?
> >
> > INSERT INTO Customers (FirstName, LastName, Email, Phone, CompanyName)
> > VALUES (wrtwrt, wrtw, wrtwrt, wrtwert, ertwrt)
> >
> > (all fields are text)
> >
> > heres the code that generates it:
> >
> > String sql = "INSERT INTO Customers (" +
> > "FirstName, LastName, Email, Phone, CompanyName)
> "
> > +
> > "VALUES (" + req.getParameter("fname") + ", " +
> > req.getParameter("lname") + ", " +
> > req.getParameter("email") + ", " +
> > req.getParameter("phone") + ", " +
> > req.getParameter("company") + ")";
> >
> > for some reason the update isn't working, just want to check theres
> nothing
> > wrong with the sring.
> >
> > I'm accessing an access db via ODBC, I'm getting a connection to the db
> ok.
> >
> > thanks,
> >
> > Paul
> >
> >
> ___________________________________________________________________________
> > To unsubscribe, send email to [EMAIL PROTECTED] and include in the
> body
> > of the message "signoff SERVLET-INTEREST".
> >
> > Archives: http://archives.java.sun.com/archives/servlet-interest.html
> > Resources: http://java.sun.com/products/servlet/external-resources.html
> > LISTSERV Help: http://www.lsoft.com/manuals/user/user.html
>
> --
> John Johnson
> Software Engineer
> Supply Chain Logic, Inc.
> 301-210-7400, x217
>
> ___________________________________________________________________________
> To unsubscribe, send email to [EMAIL PROTECTED] and include in the body
> of the message "signoff SERVLET-INTEREST".
>
> Archives: http://archives.java.sun.com/archives/servlet-interest.html
> Resources: http://java.sun.com/products/servlet/external-resources.html
> LISTSERV Help: http://www.lsoft.com/manuals/user/user.html
>
> ___________________________________________________________________________
> To unsubscribe, send email to [EMAIL PROTECTED] and include in the body
> of the message "signoff SERVLET-INTEREST".
>
> Archives: http://archives.java.sun.com/archives/servlet-interest.html
> Resources: http://java.sun.com/products/servlet/external-resources.html
> LISTSERV Help: http://www.lsoft.com/manuals/user/user.html
___________________________________________________________________________
To unsubscribe, send email to [EMAIL PROTECTED] and include in the body
of the message "signoff SERVLET-INTEREST".
Archives: http://archives.java.sun.com/archives/servlet-interest.html
Resources: http://java.sun.com/products/servlet/external-resources.html
LISTSERV Help: http://www.lsoft.com/manuals/user/user.html
