Hi Edzer,

----- "Edzer Pebesma" <edzer.pebe...@uni-muenster.de> wrote:

> Two minor issues (you might need to get a grass expert involved; don't
>
> shy away to include Markus):

That's OK, I am with the GRASS dev team ;)

> 
> 1. I'd guess grass64 refers to a grass binary configured for a 64-bits
> 
> environment, rather than a 6.4 version

It's the GRASS 6.4 startup script (which is a text file, not a binary).

> 2. on a sane system, /usr/bin should bin in your path. But OK, if it 
> works, it works.

Yes, but on a sane system, chmod (like all system management commands)
is in /bin not /usr/bin. Also, calling security-critical commands by
a user-level process without full path specification may very well
be blocked (think of a hacker trying to swap such a command for
a patched-up version to get root level access). And I assume that's
what's happening on my Ubuntu machine and the reason why the current
code does not work.

Ben

> --
> Edzer
> 
> Bastian Schäffer wrote:
> > F.Y.I.
> >
> > -------- Original-Nachricht --------
> > Betreff: [Sextante-devel] SEXTANTE GRASS integration
> > Datum: Tue, 19 Jan 2010 22:27:30 +0000 (GMT)
> > Von: Benjamin Ducke <benjamin.du...@oxfordarch.co.uk>
> > An: sextante-devel <sextante-de...@lists.forge.osor.eu>
> >
> > I have still not managed to get the GRASS modules to work under
> > SEXTANTE (stuck at the "Carpeta_GRASS_incorrecta" message).
> > But here are some notes:
> >
> > GrassAlgorithmsFactory.java, line 168:
> >
> >   Process proc = Runtime.getRuntime().exec("chmod 777" +
> > GrassUtils.getBatchJobFile());
> >
> > This did not find the "chmod" command on my system. I had to change
> it to
> > the full path "/bin/chmod".
> >
> > GrassUtils.java, line 37:
> >
> >   list.add("grass64");
> >
> > I guess this means that GRASS 6.4 is the required version? Fair
> enough, but
> > in that case I would advise changing the label for the option on
> the
> > settings
> > page from "GRASS_folder" to "GRASS 6.4 installation folder".
> >
> > SextanteConfigurationDialog.java, line 205:
> >
> >   "Carpeta_grass_incorrecta",
> >
> > I guess if it's declared like that, then the error message is
> hard-coded
> > and cannot be translated using a .properties file.
> >
> > Also, in terms of usability:
> > When the user sets a wrong GRASS folder (or mapset), then the
> settings
> > should be erased. The way it is now, a user can enter wrong
> settings,
> > reopen the settings dialog, enter the same wrong settings again and
> > won't get an error message, because the same settings do not get
> > checked twice.
> >
> > To be honest, I think the way errors in GRASS settings are handled
> > in SextanteConfigurationDialog.java should be improved.
> > The way it is, any warning message cannot differentiate whether
> > there is a problem with the GRASS installation directory or the
> > mapset (or both).
> >
> > Best,
> >
> > Ben
> >
> >
> > ------
> > Files attached to this email may be in ISO 26300 format (OASIS Open
> > Document Format). If you have difficulty opening them, please visit
> > http://iso26300.info for more information.
> >
> > _______________________________________________
> > Sextante-devel mailing list
> > sextante-de...@lists.forge.osor.eu
> > https://lists.forge.osor.eu/listinfo/sextante-devel
> >
> >   
> 
> -- 
> Edzer Pebesma
> Institute for Geoinformatics (ifgi), University of Münster 
> Weseler Straße 253, 48151 Münster, Germany. Phone: +49 251 
> 8333081, Fax: +49 251 8339763  http://ifgi.uni-muenster.de 
> http://www.52north.org/geostatistics      e.pebe...@wwu.de


------
Files attached to this email may be in ISO 26300 format (OASIS Open Document 
Format). If you have difficulty opening them, please visit http://iso26300.info 
for more information.

_______________________________________________
Sextante-users mailing list
Sextante-users@lists.forge.osor.eu
https://lists.forge.osor.eu/listinfo/sextante-users

Responder a