Sorry, I think I am running on a hot maven repo (I have confirmed that these unit tests are passing on the latest commit on the master branch); please disregard this last email.
Best regards, Miguel From: Miguel Duarte DE MORA BARROSO Sent: martes, 13 de septiembre de 2016 11:00 To: '[email protected]' <[email protected]> Subject: Master branch unit test failing Hi all, I'm working in a bug [1], and I I've finished working on it, and want to submit it to master branch - since this is a non-critical bug. Thing is, currently, master is broken due to a couple of failed unit tests: ------------------------------------------------------- T E S T S ------------------------------------------------------- .... Tests run: 10, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 13.182 sec <<< FAILURE! - in org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest deleteServiceFunction(org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest) Time elapsed: 1.934 sec <<< FAILURE! java.lang.AssertionError: null at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest.deleteServiceFunction(IosXeDataStoreAPITest.java:102) writeServiceFunction(org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest) Time elapsed: 1.903 sec <<< FAILURE! java.lang.AssertionError: null at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest.writeServiceFunction(IosXeDataStoreAPITest.java:72) readServiceFunction(org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest) Time elapsed: 0.889 sec <<< FAILURE! java.lang.AssertionError: null at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.opendaylight.sfc.sfc_ios_xe.provider.utils.IosXeDataStoreAPITest.readServiceFunction(IosXeDataStoreAPITest.java:87) Running org.opendaylight.sfc.sfc_ios_xe.provider.utils.SfcIosXeUtilsTest Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.873 sec - in org.opendaylight.sfc.sfc_ios_xe.provider.utils.SfcIosXeUtilsTest Results : Failed tests: IosXeDataStoreAPITest.deleteServiceFunction:102 null IosXeDataStoreAPITest.readServiceFunction:87 null IosXeDataStoreAPITest.writeServiceFunction:72 null Tests run: 29, Failures: 3, Errors: 0, Skipped: 0 So, it makes no sense to push the patch, since the unit test regression will fail - even before testing the patch I'm submitting (which concerns the openflow renderer). I plan to push a commit disabling the failed unit tests, to unblock the master branch, *before* pushing the patch that fixes the [1] bug. I'm informing you so that we can keep track of things, eventually have someone fix the failing unit tests, and also to make sure that this is the right course of action. Best regards, Miguel [1] - https://bugs.opendaylight.org/show_bug.cgi?id=5969
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
