I just merged the patch, thanks!!
A few suggestions:
* I rebased the patch via gerrit.
o You should make sure its rebased off the latest version of
master before submitting it.
o This way you can avoid an unnecessary Jenkins build
* When a change is for a Bugzilla bug, put the bug number in the main
git comment title, like this: "BUG 7179: No prefix required for type
parameter of SF"
o Gerrit is capable of creating the necessary URL
o This way its easier to filter and find the changes related to
bug fixes
Regards,
Brady
On 16/11/16 13:44, Swati Deshpande wrote:
Thanks Brady
Patch submitted for review https://git.opendaylight.org/gerrit/#/c/48398
Regards,
Swati
On Tue, Nov 15, 2016 at 7:34 PM, Brady Allen Johnson
<[email protected]
<mailto:[email protected]>> wrote:
Swati,
It used to be that the SF-type field had to be prefixed with that
string. This was changed so that its no longer needed, but
unfortunately the SFC UI wasnt also updated.
Go ahead and submit the patch, and I'll review it :)
Let me know if you need any help.
Regards,
Brady
On 15/11/16 12:57, Swati Deshpande wrote:
Hi
The sfc-ui (sfc.services.js) adds prefix
'service-function-type" while constructing type field for SF.
i.e if we select SF type as dpi, type gets set as
"service-function-type:dpi".
Is there any specific reason for adding this prefix?? Can it be
removed?
The prefix is the cause for bug 7179 and I would like to submit
patch for the same.
Regards,
Swati
_______________________________________________
sfc-dev mailing list
[email protected]
<mailto:[email protected]>
https://lists.opendaylight.org/mailman/listinfo/sfc-dev
<https://lists.opendaylight.org/mailman/listinfo/sfc-dev>
_______________________________________________
sfc-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/sfc-dev
