On Thu, 24 Nov 2016 08:29:29 +0000, Jan Scheurich wrote:
> This looks like a bug in OVS VXLAN tunnel port implementation (in the
> kernel datapath).

This is not a bug in the kernel datapath.

> For the OVS upstream development we'll have to make sure that the
> tunnel port implementation uses the configured (or the default)
> destination port, unless the tunnel port is explicitly configured
> with option tp_dst=flow.

This is exactly what is happening.

> To change this line in datapath/linux/compat/vxlan.c
> 
> dst_port = info->key.tp_dst ? : vxlan->cfg.dst_port;
> 
> to this to fix your issue.
> 
> dst_port = vxlan->cfg.dst_port ? : info->key.tp_dst;

No, the original (current) code is correct. It says: "use the per-packet
specified port; if the port is not specified, fall back to the one
configured on the port". Which is exactly what is needed and what is
the correct behavior.

Note that the line you're suggesting is equivalent to:

dst_port = vxlan->cfg.dst_port;

ignoring info->key.tp_dst completely.

I can't really comment on the rest of the email. It seems it's a bug
in your non-upstream patches.

 Jiri
_______________________________________________
sfc-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/sfc-dev

Reply via email to