Michael,
Thanks so much for submitting this patch, and apologies for not doing it
ourselves. As David mentioned, last week was a short week for us, plus I
was on a business trip.
Just so you know, Ive often heard us called "SFCers", although I really
like "SFCiados".
I agree with you about the static nature of the class. We'll take this
as an action item to improve the class to make a cleaner, longer-term
solution.
Regards,
Brady
On 09/12/16 09:50, David Suarez Fuentes wrote:
Hi Michael,
I +1ed the patch, Brady will merge it shortly. We had a 2 working days
week here in Madrid 😊
Best regards,
David.
------------------------------------------------------------------------
*De:* [email protected]
<[email protected]> en nombre de Michael
Vorburger <[email protected]>
*Enviado:* jueves, 8 de diciembre de 2016 15:47:29
*Para:* [email protected]
*Asunto:* Re: [sfc-dev] NOK org.opendaylight.sfc.netconf bundleState =
Failure, due to: Blueprint. Unable to find property descriptor
dataProvider on class
org.opendaylight.sfc.sfc_netconf.provider.api.SfcNetconfServiceFunctionAPI
Hello,
please merge https://git.opendaylight.org/gerrit/#/c/49151/ ASAP....
Tx,
M.
--
Michael Vorburger <[email protected] <mailto:[email protected]>>
| IRC: vorburger @freenode | ~ = http://vorburger.ch
<http://vorburger.ch/>
On Thu, Dec 8, 2016 at 11:53 AM, Michael Vorburger
<[email protected] <mailto:[email protected]>> wrote:
Dear SFCiancs (SFCiados? SFCetians?),
As part of working on a significant improvement to the odlparent
SingleFeatureTest, so that it not only does a basic feature
installation sanity check, but actually ensures that all bundles
with their respective blueprint wiring really did all fully come
up correctly (which is the big missing piece for some more sanity
IMHO), see https://git.opendaylight.org/gerrit/#/c/48901/
<https://git.opendaylight.org/gerrit/#/c/48901/>, we're seeing:
bundleState = Failure, due to: Blueprint. Unable to find property
descriptor dataProvider on class
org.opendaylight.sfc.sfc_netconf.provider.api.SfcNetconfServiceFunctionAPI.
org.osgi.service.blueprint.container.ComponentDefinitionException:
Unable to find property descriptor dataProvider on class
org.opendaylight.sfc.sfc_netconf.provider.api.SfcNetconfServiceFunctionAPI
based on my analysis, I do not think that this is an infra issues
in the new TestBundleDiag from c/48901, but suspect that your
org.opendaylight.sfc.netconf bundle actually really does have
broken BP wiring - is that possible, or am I totally off here?
Indeed SfcNetconfServiceFunctionAPI's setDataProvider() method is
static, so I don't think you can do <property name="dataProvider"
ref="dataBroker"/> for <bean id="sfcnetconfservicefunctionapi"
class="org.opendaylight.sfc.sfc_netconf.provider.api.SfcNetconfServiceFunctionAPI">
as you are in your sfc-netconf.xml ... at the very least, you
would need a fake non-static setter there, like you have for
setSfcProviderSfDescriptionMonitorAPI (although that's very ugly,
static-is-evil; but that's beyond this thread).
In order to unblock c/48901 (which is currently failing
integration/distribution due to this), would one of you be able to
resolve this in the sort of near term kind of future?
Thanks a lot,
M.
--
Michael Vorburger <[email protected]
<mailto:[email protected]>> | IRC: vorburger @freenode | ~ =
http://vorburger.ch <http://vorburger.ch/>
_______________________________________________
sfc-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/sfc-dev
