On 01/24/2017 06:17 PM, Michael Vorburger wrote: > One question around this: these look like hand-written APIs, which > really should be backed by a model. Is there a particular reason for > this? > > > using https://immutables.github.io for these could be interesting.. but > probably more of a potential next step separate follow-up, than > something to mix into this. But now that there is a super generic > String[] API anymore, which is used to be, which this addresses, moving > to adopting (e.g.) Immutables.org instead of coding those out as they > are would be useful, IMHO.
Actually, these things should have an associated yang model, from there all the stuff that immutables.org does comes out for free (in fact binding2 is using immutables internally). I mean really, https://github.com/opendaylight/genius/blob/master/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/MatchInfo.java is tied to model-defined entity. https://github.com/opendaylight/genius/blob/master/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/IPv4.java looks exactly how AD-SAL classes used to look like... Scratch that, it actually *is* a copy of an AD-SAL class: https://github.com/opendaylight/controller/blob/stable/helium/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/IPv4.java Regards, Robert
signature.asc
Description: OpenPGP digital signature
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
