Hi Vishal, The most recent Carbon CSIT run has succeeded:
https://git.opendaylight.org/gerrit/#/c/51906/ So it is possible that your review needs to be refined. That said even after the fix we have put in here: https://git.opendaylight.org/gerrit/#/c/51224/ could still see lot of functional errors in the logs in handling router deletion as below: The below exceptions are not the root-cause of associate router to l3vpn failure, but an improper cleanup can trigger stale flows to remain in hypervisors. Let me try to address these today : 2017-02-17 03:08:12,086 | INFO | nPool-1-worker-2 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 1 and max retries exceeded for for vpnName a21453b0-ce35-4e83-8d0d-f657cf11e054, rd a21453b0-ce35-4e83-8d0d-f657cf11e054 2017-02-17 03:08:18,211 | INFO | nPool-1-worker-1 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 1 and max retries exceeded for for vpnName 964e621f-0124-4786-884c-c414aeb5286c, rd 964e621f-0124-4786-884c-c414aeb5286c 2017-02-17 03:08:33,518 | INFO | nPool-1-worker-0 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 2 and max retries exceeded for for vpnName c35c4cfa-8d8f-4193-8b0a-b7c1de083473, rd c35c4cfa-8d8f-4193-8b0a-b7c1de083473 2017-02-17 03:09:00,424 | INFO | nPool-1-worker-1 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 1 and max retries exceeded for for vpnName c64a51c7-900a-45ba-bbf4-453f7d189809, rd c64a51c7-900a-45ba-bbf4-453f7d189809 2017-02-17 03:09:54,214 | INFO | nPool-1-worker-0 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 1 and max retries exceeded for for vpnName b51ec545-0839-4228-8d94-181158777176, rd b51ec545-0839-4228-8d94-181158777176 2017-02-17 03:10:31,382 | INFO | nPool-1-worker-1 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 1 and max retries exceeded for for vpnName f2327168-b083-44f8-bb6b-496363024b44, rd f2327168-b083-44f8-bb6b-496363024b44 2017-02-17 03:11:14,217 | INFO | nPool-1-worker-0 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 2 and max retries exceeded for for vpnName f873e40c-e182-4a3e-ba20-4ef4f5696274, rd f873e40c-e182-4a3e-ba20-4ef4f5696274 2017-02-17 03:11:55,682 | INFO | nPool-1-worker-3 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 4 and max retries exceeded for for vpnName 2c55b6a2-00c1-4989-8257-1e91dc9a5ec0, rd 2c55b6a2-00c1-4989-8257-1e91dc9a5ec0 2017-02-17 03:11:55,682 | INFO | nPool-1-worker-3 | VpnInstanceListener | 370 - org.opendaylight.netvirt.vpnmanager-impl - 0.4.0.SNAPSHOT | VPNInstance bailing out of wait loop as current interface count is 4 and max retries exceeded for for vpnName 2c55b6a2-00c1-4989-8257-1e91dc9a5ec0, rd 2c55b6a2-00c1-4989-8257-1e91dc9a5ec0 -- Thanks, Vivek -----Original Message----- From: Ben-Meir, Tali [mailto:[email protected]] Sent: Friday, February 17, 2017 10:59 AM To: Vishal Thapar <[email protected]>; Kochba, Alon <[email protected]>; N Vivekanandan <[email protected]> Cc: [email protected]; [email protected]; [email protected] Subject: RE: [genius-dev] [netvirt-dev] [WEATHER] Genius - Remove Deprecated DataChangeListener references Hi Vishal, Take a look at the stdout log of this gate [5] there are lots of exceptions there I haven't seen before [5] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-gate-stateful-carbon/109/archives/odl1_karaf_console.log.gz Tali -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Vishal Thapar Sent: Friday, February 17, 2017 6:17 AM To: Kochba, Alon <[email protected]>; N Vivekanandan <[email protected]> Cc: [email protected]; [email protected]; [email protected] Subject: Re: [genius-dev] [netvirt-dev] [WEATHER] Genius - Remove Deprecated DataChangeListener references Netvirt patch is failing 2 CSIT test cases [1]. First one is tempest failure TestNetworkAdvancedServerOps.test_server_connectivity_pause_unpause [2] . Other one is 'Verify L3VPN datapath with router association' [4]. May or may not be related to changes in patch. I'll tigger CSIT again but would appreciate relevant module owners to review the patch. [1] https://jenkins.opendaylight.org/releng/job/netvirt-csit-1node-openstack-newton-nodl-v2-gate-stateful-carbon/109/ [2] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-gate-stateful-carbon/109/archives/robot-plugin/log.html.gz#s1-s2-s1-t10-k3-k1-k3-k2-k1-k1-k3-k1-k3 [3] https://git.opendaylight.org/gerrit/#/c/51777/5/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/TransportZoneNotificationUtil.java@99 [4] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-gate-stateful-carbon/109/archives/robot-plugin/log.html.gz#s1-s4-s1-t15-k8-k3-k2-k1-k1-k3-k1-k3 -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Vishal Thapar Sent: 16 February 2017 23:13 To: Faseela K <[email protected]>; [email protected]; [email protected]; [email protected] Subject: Re: [netvirt-dev] [WEATHER] Genius - Remove Deprecated DataChangeListener references I've added Netvirt patch for it. https://git.opendaylight.org/gerrit/#/q/topic:abstractDCL-cleanup Regards, Vishal. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Faseela K Sent: 15 February 2017 00:56 To: Faseela K <[email protected]>; [email protected]; [email protected]; [email protected] Subject: Re: [netvirt-dev] [WEATHER] Genius - Remove Deprecated DataChangeListener references Patch on Genius for the same: https://git.opendaylight.org/gerrit/#/c/51876/ -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Faseela K Sent: Tuesday, February 14, 2017 2:36 PM To: Stephen Kitt <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected] Subject: [netvirt-dev] [WEATHER] Genius - Remove Deprecated DataChangeListener references Hi, We were planning to remove these abstract classes in GENIUS without much headache, since everyone had moved to DTCN usage. But finally figured out that there are still several references for the same. So we are planning to track this using a weather item. However, we have not yet finalized on when this gets merged. As a general heads-up, the Genius project will be dropping the deprecated base classes on DCN under mdsalutil( AsyncDataChangeListenerBase, AsyncDataChangeListenerBase, ChainableDataChangeListener, ChainableDataChangeListenerImpl, and AbstractDataChangeListener). The weather page is given below : https://wiki.opendaylight.org/view/Weather#Genius_AbstractDataChangeListener_clean-up Regards, Faseela _______________________________________________ netvirt-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/netvirt-dev _______________________________________________ netvirt-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/netvirt-dev _______________________________________________ netvirt-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/netvirt-dev _______________________________________________ genius-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/genius-dev _______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
