Thanks a lot for the pointers David! I will fix this. Thanks, Faseela
From: David Suarez [mailto:[email protected]] Sent: Friday, May 04, 2018 12:27 AM To: Faseela K <[email protected]> Cc: [email protected]; Brady Johnson <[email protected]> Subject: Re: SFC merge job failing on Oxygen Hi Faseela, I found what's going on, there are some unit tests that are failing: java.lang.NullPointerException at org.opendaylight.genius.tools.mdsal.listener.DataTreeChangeListenerActions.onDataTreeChanged(DataTreeChangeListenerActions.java:42) at org.opendaylight.genius.tools.mdsal.listener.AbstractSyncDataTreeChangeListener.onDataTreeChanged(AbstractSyncDataTreeChangeListener.java:51) at org.opendaylight.sfc.ovs.listener.SfcOvsNodeDataListenerTest.testAddNode(SfcOvsNodeDataListenerTest.java:127) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)... This would have been detected by cherry-picking locally, but not directly on Gerrit. The solution is to fix those tests so they can call the new methods as in [1]: for example: sfcOvsSffEntryDataListener.add(InstanceIdentifier.create(ServiceFunctionForwarder.class), sff); I have tried to cherry-picked [1] from Gerrit, but it fails, so either you solve the UTs on your patch or I can try to cherry-pick [1] locally. [1] https://git.opendaylight.org/gerrit/#/c/70677/4/sfc-ovs/src/test/java/org/opendaylight/sfc/ovs/listener/SfcOvsSffEntryDataListenerTest.java<https://link.getmailspring.com/link/[email protected]/0?redirect=https%3A%2F%2Fgit.opendaylight.org%2Fgerrit%2F%23%2Fc%2F70677%2F4%2Fsfc-ovs%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fsfc%2Fovs%2Flistener%2FSfcOvsSffEntryDataListenerTest.java&recipient=ZmFzZWVsYS5rQGVyaWNzc29uLmNvbQ%3D%3D> Best regards, David. On May 3 2018, at 12:17 pm, Faseela K <[email protected]<mailto:[email protected]>> wrote: Hi, My patch which got merged yesterday in Oxygen [0] is failing on merge job, but not able to figure out what the issue is. Can anyone help please? Thanks, Faseela [0] https://git.opendaylight.org/gerrit/#/c/71159/<https://link.getmailspring.com/link/[email protected]/1?redirect=https%3A%2F%2Fgit.opendaylight.org%2Fgerrit%2F%23%2Fc%2F71159%2F&recipient=ZmFzZWVsYS5rQGVyaWNzc29uLmNvbQ%3D%3D> [Open Tracking]
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
