Michael, I have the compilation problems fixed, without using "mvn -Pq". For the original patch, I started off using "mvn -Pq", but Im pretty sure I built it not using "-Pq" before uploading it.
The build problems I had today were mostly due to FindBugs and the Logger. Seems like that was updated since I first prepared this patch. I am now getting some test errors that Im currently working on. I'll upload all the fixes soon. Regards, *Brady Johnson* [email protected] On Mon, Oct 8, 2018 at 9:49 AM Brady Johnson <[email protected]> wrote: > Michael, > > Thanks for the info. I'll fix this first thing this morning. > > Regards, > > Brady > > > On Sat, Oct 6, 2018 at 11:52 PM Michael Vorburger <[email protected]> > wrote: > >> and you still have a number of other problems, incl. Mockito (and >> powermock; see >> https://wiki.opendaylight.org/view/Neon_platform_upgrade#PowerMock) >> issues. >> >> but re. the (initially posted) build failure, which is most blocking, >> inline update: >> >> On Sat, Oct 6, 2018 at 11:11 PM Michael Vorburger <[email protected]> >> wrote: >> >>> Brady, FYI there are actually more failures in SFC, seen locally when >>> built without -Pq, including: >>> >>> [ERROR] Failures: >>> [ERROR] >>> SfcProviderServiceChainAPITest.testCreateReadServiceFunctionChain:79 Must >>> be equal expected:<null> but was:<[]> >>> [ERROR] Errors: >>> [ERROR] >>> >>> ServiceFunctionClassifierListenerTest.testOnServiceFunctionClassifierRemoved:109 >>> NullPointer >>> [ERROR] >>> >>> ServiceFunctionClassifierListenerTest.testOnServiceFunctionClassifierUpdated:158 >>> NullPointer >>> [INFO] >>> [ERROR] Tests run: 105, Failures: 1, Errors: 2, Skipped: 1 >>> >>> >>> >>> On Sat, Oct 6, 2018 at 4:08 PM Michael Vorburger <[email protected]> >>> wrote: >>> >>>> Brady, any chance you could fix this ASAP? Thanks! >>>> >>>> Dear maintainers of project sfc, >>>> >>>> While verifying the proposed cross-projects changes on managed >>>> topic:neon-mri together, your project failed to build; please see >>>> https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/integration-multipatch-test-neon/54/console.log.gz >>>> . >>>> >>> >> [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile >> (default-testCompile) on project sfc-genius-utils: Compilation failure: >> Compilation failure: >> >> [ERROR] >> /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[39,88] >> package >> org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana._if.type.rev140508 >> does not exist >> [ERROR] >> /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[101,36] >> cannot find symbol >> [ERROR] symbol: class L2vlan >> [ERROR] location: class >> org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest >> [ERROR] >> /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[186,36] >> cannot find symbol >> [ERROR] symbol: class L2vlan >> [ERROR] location: class >> org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest >> [ERROR] >> /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[240,36] >> cannot find symbol >> [ERROR] symbol: class L2vlan >> [ERROR] location: class >> org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest >> >> I've taken the liberty to comment this .setType(L2vlan.class) out x3 with >> a " TODO FIXME ", to at least unblock the quick build, see >> https://git.opendaylight.org/gerrit/#/c/76404/4..5/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java >> - you'll obviously want to fix that. >> >> You can locally reproduce this via a `mvn -Pq clean install` of the >>>> changed artifacts from your dependencies, and then building your project >>>> with it: >>>> >>>> https://git.opendaylight.org/gerrit/#/q/topic:neon-mri >>>> >>>> Please raise a similar change for your project which fixes this >>>> problem. Then set its topic to 'neon-mri', and reply to this email to ask >>>> for a new build on this managed topic. If you don't hear from me anymore, >>>> then all is good; otherwise I will email this project mailing list again >>>> with a new email similar to this one. >>>> >>>> Yours sincerely, >>>> M. for the ODL Bot <https://github.com/vorburger/opendaylight-bot> >>>> >>>> >>>> https://git.opendaylight.org/gerrit/#/q/topic:neon-mri >>>> >>>> >>>> https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/integration-multipatch-test-neon/54/console.log.gz >>>> >>>> Tx, >>>> M. >>>> -- >>>> Michael Vorburger, Red Hat >>>> [email protected] | IRC: vorburger @freenode | ~ = >>>> http://vorburger.ch >>>> >>>
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
