+1 on that - Jaime, thanks a bunch! On Tue, Mar 12, 2019 at 1:01 PM Jamo Luhrsen <[email protected]> wrote:
> Neon is locked, so SFC patches will have to be merged by someone with > privileges. > > But, I think if we are going to re-spin for BGP, it's a no brainer to > get this one in too. > > Jaime, thanks a bunch for the recent work :) > > JamO > > On 3/12/19 12:50 PM, Abhijit Kumbhare wrote: > > If the comments are addressed, then Yi can you merge the change? We will > likely need to make a build anyway for the > > BGPCEP issue - if we do it will be picked up in Neon - otherwise in Neon > SR1. > > > > On Tue, Mar 12, 2019 at 12:42 PM Jaime Caamaño Ruiz <[email protected] > <mailto:[email protected]>> wrote: > > > > Ok for me. Just letting you know that I addressed all the comments so > > everything should be ready for merge. > > > > BR > > Jaime. > > > > -----Original Message----- > > From: Abhijit Kumbhare <[email protected] <mailto: > [email protected]>> > > To: Yi Yang (杨燚)-云服务集团 <[email protected] <mailto: > [email protected]>>, Daniel De La Rosa <ddelar > > [email protected] <mailto:[email protected]>>, > [email protected] <mailto:[email protected]> > > Cc: [email protected] <mailto: > [email protected]> <[email protected] > > <mailto:[email protected]>>, > > [email protected] <mailto: > [email protected]> <[email protected] > > <mailto:[email protected]> > > m>, [email protected] <mailto:[email protected]> < > [email protected] <mailto:[email protected]>>, > > [email protected] <mailto:[email protected]> < > [email protected] > > <mailto:[email protected]>>, > > [email protected] <mailto: > [email protected]> <[email protected] > > <mailto:[email protected]>>, > > [email protected] <mailto:[email protected]> <[email protected] > <mailto:[email protected]>>, [email protected] > > <mailto:[email protected]> <abelur > > @linuxfoundation.org <http://linuxfoundation.org>>, > [email protected] > > <mailto:[email protected]> <integrat > > [email protected] <mailto: > [email protected]>>, [email protected] > > <mailto:[email protected]> <sfc-de > > [email protected] <mailto:[email protected]>>, > [email protected] <mailto:[email protected]> > > <[email protected] <mailto:[email protected]>>, > > [email protected] <mailto:[email protected]> <[email protected] > <mailto:[email protected]>> > > Subject: Re: [integration-dev] SFC issue > > Date: Tue, 12 Mar 2019 11:08:52 -0700 > > > > Jamo, Jaime, Yi, Daniel & folks, > > > > Since we have roughly a solution on hand but it may take a few days > to > > vet it out and to avoid the cycle of one more round of project > > approvals - I suggest we defer this issue to SR1 unless we do a > respin > > of the Neon build for the BGPCEP issue. What do you folks think? > > > > Thanks, > > Abhijit > > > > > > On Mon, Mar 11, 2019 at 6:38 PM Abhijit Kumbhare < > [email protected] <mailto:[email protected]> > > > wrote: > > > Thanks for your comments Yi. > > > > > > On Mon, Mar 11, 2019 at 6:11 PM Yi Yang (杨燚)-云服务集团 > <[email protected] > > > om> wrote: > > > > Abhijit, I think it will be better that Jaime himself decides > how > > > > to proceed this, Jaime is current sfc committer. Jaime still > need > > > > to fix comments in these two changes. > > > > > > > > 发件人: Abhijit Kumbhare [mailto:[email protected] <mailto: > [email protected]>] > > > > 发送时间: 2019年3月12日 1:59 > > > > 收件人: Jaime Caamano <[email protected] <mailto:[email protected] > >> > > > > 抄送: Abhijit Kumbhare <[email protected] <mailto: > [email protected]>>; Dayavanti > > > > Gopal Kamath <[email protected] <mailto: > [email protected]>>; Faseela K <fase > > > > [email protected] <mailto:[email protected]>>; > [email protected] > > <mailto:[email protected]>; david.suarez.fuen > > > > [email protected] <mailto:[email protected]>; Yi Yang (杨燚)-云服务集团 < > [email protected] > > <mailto:[email protected]>>; abelur@lin > > > > uxfoundation.org <http://uxfoundation.org>; > [email protected] > > <mailto:[email protected]>; sfc-dev@l > > > > ists.opendaylight.org <http://ists.opendaylight.org>; > [email protected] > > <mailto:[email protected]>; shague@redhat. > > > > com; [email protected] <mailto:[email protected]>; Luis > Gomez Palacios <[email protected] > > <mailto:[email protected]>> > > > > 主题: Re: [integration-dev] SFC issue > > > > > > > > Thanks Jaime! When Yi/other SFC committer comes online - > perhaps he > > > > can merge the change - and we can make another build? > > > > > > > > On Mon, Mar 11, 2019 at 10:46 AM Jaime Caamaño Ruiz > <jcaamano@suse. > > > > de> wrote: > > > > > +Luis > > > > > > > > > > Tested patches [1] & [2] with sandbox job [3]. > > > > > > > > > > Patch [1] deals with an issue in the validator that correctly > > > > > changes > > > > > some error scenarios from HTTP 500 to HTTP 400. I suggest the > > > > > patches > > > > > to be included pre-SR1 if possible, since this is an API kinda > > > > > change. > > > > > > > > > > [1] https://git.opendaylight.org/gerrit/#/c/80769/ > > > > > [2] https://git.opendaylight.org/gerrit/#/c/80766/ > > > > > [3] > https://jenkins.opendaylight.org/sandbox/job/jaicaa-sfc-csit- > > > > > 3node-docker-full-deploy-all-neon/2/ > > > > > > > > > > BR > > > > > Jaime. > > > > > > > > > > -----Original Message----- > > > > > From: Abhijit Kumbhare <[email protected] > <mailto:[email protected]>> > > > > > To: Dayavanti Gopal Kamath < > [email protected] <mailto: > [email protected]>>, > > > > > Faseela K <[email protected] <mailto: > [email protected]>>, [email protected] > > <mailto:[email protected]> > > > > > <bradya > > > > > [email protected] <mailto:[email protected]>>, > [email protected] > > <mailto:[email protected]> > > > > > <david.suarez.fu > > > > > [email protected] <mailto:[email protected]>>, Yi Yang -云服务集团 > (杨燚) <[email protected] > > <mailto:[email protected]>>, > > > > > [email protected] <mailto:[email protected]> > <[email protected] > > <mailto:[email protected]>>, > > > > > integration- > > > > > [email protected] <mailto:[email protected]> > <[email protected] > > > > > g>, > > > > > [email protected] <mailto: > [email protected]> <[email protected] > > <mailto:[email protected]>>, > > > > > [email protected] <mailto: > [email protected]> <[email protected] > > <mailto:[email protected]>>, > > > > > [email protected] <mailto:[email protected]> < > [email protected] <mailto:[email protected]>>, > > [email protected] <mailto:[email protected]> <vthapa > > > > > r@redh > > > > > at.com <http://at.com>>, [email protected] <mailto: > [email protected]> > > > > > Subject: SFC issue > > > > > Date: Mon, 11 Mar 2019 17:23:08 +0000 > > > > > > > > > > Adding SFC and integration lists: > > > > > > > > > > Thanks Yi! > > > > > > > > > > So, SFC folks (Brady, Jaime, etc.) & Jamo - from Yi's email > this > > > > > issue > > > > > does seem "non-critical" - doesn't it? And we should mark the > > > > > issue in > > > > > the spreadsheet to be "Okay" and pick up the CSIT test changes > > > > > proposed > > > > > by Yi for SR1? > > > > > > > > > > Descriptions of HTTP codes: > > > > > > > > > > 400 Bad Request > > > > > The server cannot or will not process the request due to an > > > > > apparent > > > > > client error (e.g., malformed request syntax, size too large, > > > > > invalid > > > > > request message framing, or deceptive request routing). > > > > > > > > > > 404 Not Found > > > > > The requested resource could not be found but may be > available in > > > > > the > > > > > future. Subsequent requests by the client are permissible. > > > > > > > > > > Yi - the change you make the following change in the check to > be > > > > > from > > > > > 404 to 400: > > > > > > > > > > "Should Be Equal As Strings ${resp.status_code} 404" > > > > > > > > > > Also question - should we wild card this check to catch both > HTTP > > > > > codes > > > > > "400" and "404"? > > > > > > > > > > > > > > > On 3/10/19, 8:33 PM, "Yi Yang -云服务集团 (杨燚)" < > [email protected] <mailto:[email protected]> > > > > > > > > > > > wrote: > > > > > > > > > > Thanks Jamo, I checked test log, it seems http return > status > > > > > code > > > > > is changed, http return status code is 404 before, but not it > is > > > > > 400 > > > > > now, sfc has not been changed very long, I submitted a gerrit > > > > > change ht > > > > > tps://git.opendaylight.org/gerrit/#/c/80756/ < > http://git.opendaylight.org/gerrit/#/c/80756/> and pushed a sandbox > > > > > check > > > > > for sfc-csit-3node-docker-full-deploy-all-neon, you can take > it > > > > > to > > > > > avoid sfc is excluded in neon release. > > > > > > > > > > -----邮件原件----- > > > > > 发件人: Abhijit Kumbhare [mailto: > [email protected] <mailto:[email protected]>] > > > > > 发送时间: 2019年3月11日 10:06 > > > > > 收件人: Jamo Luhrsen <[email protected] <mailto: > [email protected]>>; Yi Yang (杨燚)-云服务集团 > > > > > <yangyi > > > > > [email protected] <mailto:[email protected]>>; Dayavanti Gopal > Kamath <dayavanti.gopal.kamath@er > > > > > icsson > > > > > .com>; [email protected] <mailto:[email protected]>; > [email protected] <mailto:[email protected]>; > > ddelarosa@luminan > > > > > etwork > > > > > s.com <http://s.com>; Faseela K <[email protected] > <mailto:[email protected]>>; abelur@linuxfoundation > > > > > .org; > > > > > [email protected] <mailto:[email protected]>; > [email protected] <mailto:[email protected]>; > > [email protected] > > > > > om; br > > > > > [email protected] <mailto:[email protected]>; > [email protected] > > <mailto:[email protected]>; jcaama > > > > > no@sus > > > > > e.com <http://e.com> > > > > > 抄送: Nishant Saurabh <[email protected] > <mailto:[email protected]>> > > > > > 主题: Re: 答复: SFC project - maintenance mode or active > > > > > > > > > > Understood. > > > > > > > > > > On 3/10/19, 6:06 PM, "Jamo Luhrsen" <[email protected] > <mailto:[email protected]>> > > > > > wrote: > > > > > > > > > > Yi, > > > > > > > > > > you need to use the logs server to see the logs, not > the > > > > > links > > > > > from jenkins. I know it's > > > > > not intuitive, but it helps our jenkins server keep up > > > > > with > > > > > things to offload the logs. > > > > > here: > > > > > > > > > > https://logs.opendaylight.org/releng/vex-yul-odl-jenkins- > > > > > 1/sfc- > > > > > csit-3node-docker-full-deploy-all-neon/201/robot- > > > > > plugin/log.html.gz > > > > > > > > > > As for the "non-critical" tag you saw Abhijit, that is > > > > > just > > > > > default for robot to > > > > > show that. We don't use critical vs non-critical, so > you > > > > > can > > > > > ignore it. > > > > > > > > > > As for only 2 failures not being a big deal, that may > be > > > > > true, > > > > > but the reason we > > > > > are discussing is that those 2 failures are not there > in > > > > > fluorine, so it's a regression > > > > > in neon and we try to avoid having regressions between > > > > > releases. > > > > > > > > > > Thanks to everyone for taking time out on their > weekend. > > > > > > > > > > JamO > > > > > > > > > > On 3/10/19 5:33 PM, Yi Yang (杨燚)-云服务集团 wrote: > > > > > > I don't intend to fix it, but only 2 of 32 test > cases > > > > > are > > > > > failed, so they aren't big issues, anybody is still active in > sfc > > > > > project? I think it is more reasonable to delay them to neon > SR1. > > > > > > > > > > > > I can check the issues, but I'm not sure I can fix > them > > > > > because I didn't develop it very long. > > > > > > > > > > > > BTW, > https://jenkins.opendaylight.org/releng/job/sfc-cs > > > > > it-3no > > > > > de-docker-full-deploy-all-neon/201/robot/report/report.html > and > > > > > https:/ > > > > > / > jenkins.opendaylight.org/releng/job/sfc-csit-3node-docker-full- > > < > http://jenkins.opendaylight.org/releng/job/sfc-csit-3node-docker-full-> > > > > > deploy- > > > > > all-neon/201/robot/report/log.html can't be accessed, can you > > > > > help send > > > > > correct links for failure log? > > > > > > > > > > > > -----邮件原件----- > > > > > > 发件人: Abhijit Kumbhare [mailto: > abhijit.kumbhare@ericsson <mailto:abhijit.kumbhare@ericsson> > > > > > .com] > > > > > > 发送时间: 2019年3月11日 8:18 > > > > > > 收件人: Jamo Luhrsen <[email protected] <mailto: > [email protected]>>; Dayavanti > > > > > Gopal > > > > > Kamath <[email protected] <mailto: > [email protected]>>; Luis Gomez Palacios > > > > > <ecel > > > > > [email protected] <mailto:[email protected]>>; Anil Vishnoi < > [email protected] <mailto:[email protected]>>; > > Daniel De La > > > > > Rosa > > > > > <[email protected] <mailto: > [email protected]>>; Faseela K <[email protected] > > <mailto:[email protected]> > > > > > >; > > > > > Anil Belur <[email protected] <mailto: > [email protected]>>; Sam Hague <shague@redhat > > > > > .com>; > > > > > Vishal Thapar <[email protected] <mailto:[email protected]>>; > Prem Sankar Gopannan <pgopann > > > > > an@lum > > > > > inanetworks.com <http://inanetworks.com>>; Brady Johnson < > [email protected] > > <mailto:[email protected]>>; Yi > > > > > Yang > > > > > (杨燚)-云服务集团 <[email protected] <mailto:[email protected]>>; > David Suarez Fuentes > > > > > <david.suarez.fu > > > > > [email protected] <mailto:[email protected]>>; Jaime Caamaño < > [email protected] <mailto:[email protected]>> > > > > > > 抄送: Nishant Saurabh <[email protected] > <mailto:[email protected]>> > > > > > > 主题: Re: SFC project - maintenance mode or active > > > > > > > > > > > > Adding some existing SFC members including Brady, > > > > > David, > > > > > Jaime and Yi Yang. I know Yi is an advisory committer. > Assuming > > > > > Daya's > > > > > team can fix it at a later date (SR1 or some other SR and > revive > > > > > SFC), > > > > > can one of you guys also check how serious is the SFC CSIT > > > > > failure? I > > > > > had already sent an email about this - with a chance for SFC > to > > > > > respond > > > > > by Tuesday (but earlier will be better) before we have to > move it > > > > > out > > > > > of Neon. > > > > > > > > > > > > The sign-off sheet is here: > https://docs.google.com/spr > > > > > eadshe > > > > > > ets/d/1sIoApv2fFp0wJcPK7m6lQDtjbUonRANrs5upSeD_DyI/edit#gid=14754 > > > > > 2669 > > > > > > > > > > > > The CSIT failure that Jamo mentions is here: > https://je > > > > > nkins. > > > > > > opendaylight.org/releng/job/sfc-csit-3node-docker-full-deploy- > > < > http://opendaylight.org/releng/job/sfc-csit-3node-docker-full-deploy-> > > > > > all- > > > > > neon/201/. > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > integration-dev mailing list > > > > > [email protected] <mailto: > [email protected]> > > > > > > https://lists.opendaylight.org/mailman/listinfo/integration-dev > > > > > > _______________________________________________ > > integration-dev mailing list > > [email protected] > > https://lists.opendaylight.org/mailman/listinfo/integration-dev > > >
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
