On Mon, Mar 10, 2008 at 7:19 AM, Dermot McCluskey
<dermot.mccluskey at sun.com> wrote:
> Stefan,
>
>  usr/src/lib/libmng/Makefile.sfw
>  - line 143: shouldn't you build against zlib from proto, not /usr, as for 
> lcms?
>   also, where is usr/src/lib/lcms/Makefile.sfw picking up zlib from?

Technically the include and lib or lib/${MACH64} directories from the
proto area should be passed in by default by the build system, but
evidently they are not. Fixed by adding them to Makefile.sfw.

>  usr/src/lib/lcms/sunman-stability
>  - line 26: references PCRE instead of lcms.

Fixed.

>  usr/src/pkgdefs/SUNWlcms/depend
>  - is there really a runtime dependency on all those -devel pkgs?
>   (other SFW pkgs don't seem to do this)

Fixed -- removed the *-devel dependencies.

>  And a few nits:
>  usr/src/pkgdefs/SUNWlcms/prototype_com
>  - a few lines not in alphabetical order (50, 57)

Fixed.

>  usr/src/lib/libmng/*
>  - all files with Copyright message have 2007, instead of 2008

Fixed.

Thank you!!

--Stefan

---
Stefan Teleman
KDE e.V.
stefan.teleman at gmail.com

Reply via email to