On 06/05/2012 08:16 PM, Christoph Hellwig wrote: > Use the out and done labels more consistently and flatten the control flow. > Also return actual error values instead of -1 to the caller in all cases > to allow for more fine grained error handling in the future.
This early refactor doesn't give us any benefit when upper layer doesn't handle fine grained error value. And return EIO all the way down for error case doesn't make sense either. I think we'd better leave as is and modify it when we really have this fine grained handling in do_recover_object(). Thanks, Yuan -- sheepdog mailing list [email protected] http://lists.wpkg.org/mailman/listinfo/sheepdog
