At Fri, 29 Jun 2012 17:38:24 +0200,
Christoph Hellwig wrote:
> >
> > > goto done;
> > > }
> > > -
> > > - create = 1;
> > > - } else if (acb->aiocb_type == AIOCB_WRITE_UDATA
> > > - && !is_data_obj_writable(inode, idx)) {
> > > - /* Copy-On-Write */
> > > - create = 1;
> > > - old_oid = oid;
> > > - flags = SD_FLAG_CMD_COW;
> > > + break;
> > > + case AIOCB_WRITE_UDATA:
> >
> > Wrong indentation.
>
> Where? At least I can't find anything obvious and checkpath.pl is fine
> with the patch, too.
It seems that there is a redundant space before "case AIOCB_WRITE_UDATA:".
==
$ ./scripts/checkpatch.pl your.patch
ERROR: switch and case should be at the same indent
#92: FILE: block/sheepdog.c:1560:
+ switch (acb->aiocb_type) {
[...]
+ case AIOCB_WRITE_UDATA:
total: 1 errors, 0 warnings, 55 lines checked
c.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
--
sheepdog mailing list
[email protected]
http://lists.wpkg.org/mailman/listinfo/sheepdog
