On 07/19/2012 11:10 AM, Yunkai Zhang wrote: > They are two things, I can't fold them. > > 1) I'm not against to rename is_zk_unblock, when is_zk_unblock is > true, it means zk_queue_pop() was called by zk_unblock(). Maybe we can > rename it to called_by_zk_unblock. > > 2) zk_notify_blocked, means whether there is unfunished BLOCK event.
I don't read the code and just skipped over it actually, and I am not against to merge this patch, What I am really concerned is that zookeeper driver might suffer code readability/quality and lack of peer reviews. So I'd suggest you add more comments to newly introduced variables. Thanks, Yuan -- sheepdog mailing list [email protected] http://lists.wpkg.org/mailman/listinfo/sheepdog
