On Sat, Sep 1, 2012 at 8:01 PM, MORITA Kazutaka <[email protected]> wrote: > At Fri, 31 Aug 2012 14:46:20 +0800, > Liu Yuan wrote: >> -static const char *short_options = "c:dDfghl:op:P:s:w:y:z:"; >> +static const char *short_options = "c:dDfghl:op:P:s:t:w:y:z:"; >> >> static void usage(int status) >> { >> @@ -78,7 +83,8 @@ Options:\n\ >> -p, --port specify the TCP port on which to listen\n\ >> -P, --pidfile create a pid file\n\ >> -s, --disk-space specify the free disk space in megabytes\n\ >> - -w, --enable-cache enable object cache and specify the max size (M) >> and mode\n\ >> + -t, --timeout specify timeout to detect membership change for >> Zookeeper\n\ > > This is a zookeeper specific option. Can we specify it in the '-c' > option? For example, > > $ sheep /store -c > zookeeper:timeout=10,server=127.0.0.1:3000;127.0.0.1:3001;127.0.0.1:3002
Keeping backward compatibility is important so that this patch will not break user's boot script. How about using this form: $ sheep /store -C zookeeper:127.0.0.1:3000;127.0.0.1:3001;127.0.0.1:3002,timeout=10 > > Thanks, > > Kazutaka > -- > sheepdog mailing list > [email protected] > http://lists.wpkg.org/mailman/listinfo/sheepdog -- Yunkai Zhang Work at Taobao -- sheepdog mailing list [email protected] http://lists.wpkg.org/mailman/listinfo/sheepdog
