On Mon, Aug 11, 2014 at 10:30:04AM +0900, Hitoshi Mitake wrote:
> At Fri, 8 Aug 2014 14:50:07 +0800,
> Liu Yuan wrote:
> >
> > Reported-by: Valerio Pachera <siri...@gmail.com>
> > Signed-off-by: Liu Yuan <namei.u...@gmail.com>
> > ---
> > sheep/group.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sheep/group.c b/sheep/group.c
> > index 06a80bd..08e3884 100644
> > --- a/sheep/group.c
> > +++ b/sheep/group.c
> > @@ -979,7 +979,7 @@ static int send_join_request(void)
> > {
> > struct sd_node *n = &sys->this_node;
> >
> > - sd_info("%s", node_to_str(n));
> > + sd_info("%s going to rejoin the cluster", node_to_str(n));
>
> send_join_request() is also called in create_cluster(). So
> unconditionally logging "rejoin" is confusing log for users.
>
> Change type of send_join_request() from
> int send_join_request(void)
> to
> int send_join_request(bool rejoin)
> and change log based on the new parameter rejoin would be good.
>
> Thanks,
> Hitoshi
Probably "going to join the cluster" is better and save us from extra para. With
this message, people can be notificed that there is a join process for this node
and can infer the zookeeper auto-reconnect has happened.
I'll update v2.
Thanks
Yuan
--
sheepdog mailing list
sheepdog@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/sheepdog
