On Tue, Jan 20, 2015 at 11:44:53AM +0800, hujianyang wrote: > On 2015/1/20 11:01, Hitoshi Mitake wrote: > > At Tue, 20 Jan 2015 11:46:32 +0900, > > Hitoshi Mitake wrote: > >> > >> Cc: hujianyang <[email protected]> > >> Signed-off-by: Hitoshi Mitake <[email protected]> > >> --- > >> sbd/sheep_block_device.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Dropping it. The version information should be described about the > > interfaces. > > > > Thanks, > > Hitoshi > > > > Seems *kstrtoul* is introduce into mainline since commit 33ee3b2e2: > > commit 33ee3b2e2eb9b4b6c64dcf9ed66e2ac3124e748c > Author: Alexey Dobriyan <[email protected]> > Date: Tue Mar 22 16:34:40 2011 -0700 > > kstrto*: converting strings to integers done (hopefully) right > > An old kernel maybe not support this interface, but I don't like > the module code is written as: > > #ifdef KERNEL_VERSION<(x,x,x) > ... > #else > ... > #endif > > What's your opinion?
This is the suggested method to work around backcompatiblity issue in order to support different kernels (both old and new) IMHO. If there is BETTER one, I'd be pleased to see it. Thanks Yuan -- sheepdog mailing list [email protected] https://lists.wpkg.org/mailman/listinfo/sheepdog
