At Mon, 16 Mar 2015 21:13:29 +0800, Liu Yuan wrote: > > How about make 'dog vdi clone --no-share' as the default clone operation? And > we can add dog vdi clone --share to keep old behavior as optional. By this > manner, --no-share will save us from this kind of subtle problem. And your > team > problem about vdi exhaustion will be achieved :).
--no-share option disables thin provisioing. It shouldn't be a default option, IMHO. > > This manner is not perfect, but it will benefit us: > > 1. stable code base since old algorithm is long tested. Hitoshi's patch enables the stable algorithm by default. Isn't it enough? > 2. we won't degrate vdi_lookup I'm still not sure which code in vdi_lookup() is a problem. The problem happens even when we disable VID garbage collection? Thanks, Kazutaka -- sheepdog mailing list [email protected] https://lists.wpkg.org/mailman/listinfo/sheepdog
