I have a new webrev that addresses all the issues mentioned so far, except the question of crontab verifying the values given for the variables. Thank you for the comments, especially the "pedantic" ones.
There are two reasons I have not verified the variables: 1) They may be right when crontab runs but when we get to execution they may no longer be o.k. Eg, the directory specified could have been deleted or in the NFS case be no longer accessible or even the shell specified could no longer be available. The reverse is also true, the directory could be created later. Hence I question the point of checking at all. 2) For TZ and SHELL exactly how you test their correctness is unclear. For TZ I could add a hook into libc to get it to be able to do the check (and have another ARC case) but for shell, short of actually executing the shell there is no way to verify that the shell is good. Anyway the new webrev is here: http://cr.opensolaris.org/~cjg/cron/webrev2/ any further comments welcome. -- This message posted from opensolaris.org
