On Fri, Feb 11, 2011 at 4:23 PM, Roland Mainz <roland.ma...@nrubsig.org> wrote: > Hi! > > ---- > > I'd like to request another code review for the upcoming > ksh93-integration+POSIX utility update3 putback. I hope this is the > final round now that all other feedback has been integrated and the > codebase has been updated to match ast-ksh.2011-02-08. > > > Webrev can be found at > http://cr.opensolaris.org/~gisburn/on_posix_utility_update2_201100211_017/
I'm still not happy with the number of spelling errors in many comments of the code, including the sun_solaris* testsuite modules. Other than that, a detailed examination of the AST sources and the Solaris makefiles doesn't reveal new issues and the old issues, except spelling, have all been addressed to my full satisfaction. I'm happy to sign this off *IF* you promise to file bug reports at illumos.org and bugs.opensolaris.org to address the spelling errors in a future putback and Venky as your sponsor agrees to this. Irek _______________________________________________ shell-discuss mailing list shell-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/shell-discuss
