svn commit: r673680 - in /incubator/shindig/trunk/php/src/socialrest: ActivityHandler.php http/RestServlet.php

[chabotc]

Author: chabotc
Date: Thu Jul  3 06:56:38 2008
New Revision: 673680

URL: http://svn.apache.org/viewvc?rev=673680&view=rev
Log:
Better error handling in request item creation

Modified:
    incubator/shindig/trunk/php/src/socialrest/ActivityHandler.php
    incubator/shindig/trunk/php/src/socialrest/http/RestServlet.php

Modified: incubator/shindig/trunk/php/src/socialrest/ActivityHandler.php
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/php/src/socialrest/ActivityHandler.php?rev=673680&r1=673679&r2=673680&view=diff
==============================================================================
--- incubator/shindig/trunk/php/src/socialrest/ActivityHandler.php (original)
+++ incubator/shindig/trunk/php/src/socialrest/ActivityHandler.php Thu Jul  3 
06:56:38 2008
@@ -58,13 +58,19 @@
         * /activities/{userId}/@self
         *
         * examples:
+        * /activities/@viewer/@self/@app
         * /activities/john.doe/@self
         * - postBody is an activity object
         */
        public function handlePost(RestRequestItem $requestItem)
        {
+               $requestItem->parseUrlWithTemplate(self::$ACTIVITY_ID_PATH);
                //TODO: do we need to add groups here?
-               return $this->service->createActivity($requestItem->getUser(), 
$requestItem->getPostData(), $requestItem->getToken());
+               if ($this->service->createActivity($requestItem->getUser(), 
$requestItem->getPostData(), $requestItem->getToken())) {
+                       return new ResponseItem(null, null, '');
+               } else {
+                       return new ResponseItem(BAD_REQUEST, "You can't delete 
activities. ", null);
+               }
        }
 
        /**

Modified: incubator/shindig/trunk/php/src/socialrest/http/RestServlet.php
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/php/src/socialrest/http/RestServlet.php?rev=673680&r1=673679&r2=673680&view=diff
==============================================================================
--- incubator/shindig/trunk/php/src/socialrest/http/RestServlet.php (original)
+++ incubator/shindig/trunk/php/src/socialrest/http/RestServlet.php Thu Jul  3 
06:56:38 2008
@@ -108,6 +108,7 @@
        private function getResponseItem(RestRequestItem $requestItem)
        {
                $path = $this->getRouteFromParameter($requestItem->getUrl());
+               $class = false;
                switch ($path) {
                        case 'people':
                                $class = 'PersonHandler';
@@ -123,7 +124,7 @@
                                $response = new ResponseItem(NOT_IMPLEMENTED, 
"{$path} is not implemented");
                                break;
                }
-               if (class_exists($class, true)) {
+               if ($class && class_exists($class, true)) {
                        $class = new $class(null);
                        $response = $class->handleMethod($requestItem);
                }