svn commit: r706356 - in /incubator/shindig/trunk/java/gadgets/src: main/java/org/apache/shindig/gadgets/http/HttpResponse.java test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java

[etnu]

Author: etnu
Date: Mon Oct 20 11:20:46 2008
New Revision: 706356

URL: http://svn.apache.org/viewvc?rev=706356&view=rev
Log:
Count 400 as an error and add tests to ensure all codes are treated correctly.


Modified:
    
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
    
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java

Modified: 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java?rev=706356&r1=706355&r2=706356&view=diff
==============================================================================
--- 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
 (original)
+++ 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
 Mon Oct 20 11:20:46 2008
@@ -179,10 +179,10 @@
   }
 
   /**
-   * @return 400
+   * @return True if the status code is considered to be an error.
    */
   public boolean isError() {
-    return httpStatusCode > 400;
+    return httpStatusCode >= 400;
   }
 
   /**

Modified: 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java?rev=706356&r1=706355&r2=706356&view=diff
==============================================================================
--- 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java
 (original)
+++ 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java
 Mon Oct 20 11:20:46 2008
@@ -306,4 +306,22 @@
       assertNotNull("Null header not removed.", key);
     }
   }
+
+  public void testIsError() {
+    // These aren't all valid status codes, but they're reserved in these 
blocks. Changes
+    // would be required to the HTTP standard anyway before this test would be 
invalid.
+    for (int i = 100; i < 400; i += 100) {
+      for (int j = 0; j < 10; ++j) {
+        HttpResponse response = new 
HttpResponseBuilder().setHttpStatusCode(i).create();
+        assertFalse("Status below 400 considered to be an error", 
response.isError());
+      }
+    }
+
+    for (int i = 400; i < 600; i += 100) {
+      for (int j = 0; j < 10; ++j) {
+        HttpResponse response = new 
HttpResponseBuilder().setHttpStatusCode(i).create();
+        assertTrue("Status above 400 considered to be an error", 
response.isError());
+      }
+    }
+  }
 }