svn commit: r757174 - in /incubator/shindig/trunk/java/gadgets/src: main/java/org/apache/shindig/gadgets/spec/UserPref.java test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java

[vsiveton]

Author: vsiveton
Date: Sun Mar 22 12:00:05 2009
New Revision: 757174

URL: http://svn.apache.org/viewvc?rev=757174&view=rev
Log:
SHINDIG-459:  Shindig GadgetSpec returns invalid XML with UserPrefs and 
EnumValue
Submitted by: Henning Schmiedehausen

o patch applied
o added a small test case

Modified:
    
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java
    
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java

Modified: 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java?rev=757174&r1=757173&r2=757174&view=diff
==============================================================================
--- 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java
 (original)
+++ 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java
 Sun Mar 22 12:00:05 2009
@@ -148,11 +148,10 @@
     if (enumValues.isEmpty()) {
       buf.append("/>");
     } else {
-      buf.append('\n');
+      buf.append(">\n");
       for (Map.Entry<String, String> entry : enumValues.entrySet()) {
         buf.append("<EnumValue value=\"")
            .append(entry.getKey())
-           .append("\" value=\"")
            .append("\" display_value=\"")
            .append(entry.getValue())
            .append("\"/>\n");

Modified: 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java?rev=757174&r1=757173&r2=757174&view=diff
==============================================================================
--- 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java
 (original)
+++ 
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/UserPrefTest.java
 Sun Mar 22 12:00:05 2009
@@ -100,4 +100,14 @@
       // OK
     }
   }
+
+  public void testToString() throws Exception {
+    String xml = "<UserPref name=\"name\" 
display_name=\"__MSG_display_name__\" "
+        + "default_value=\"__MSG_default_value__\" required=\"false\" "
+        + "datatype=\"enum\">"
+        + "<EnumValue value=\"0\" display_value=\"__MSG_dv__\"/>"
+        + "</UserPref>";
+    UserPref userPref = new UserPref(XmlUtil.parse(xml));
+    assertEquals(xml, userPref.toString().replaceAll("\n", ""));
+  }
 }