Author: vsiveton
Date: Wed Apr 1 12:51:42 2009
New Revision: 760870
URL: http://svn.apache.org/viewvc?rev=760870&view=rev
Log:
SHINDIG-849: MakeRequestHandler should not try to do anything with the response
body if return code is != 200
Submitted by: Henning Schmiedehausen
o patch applied
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java?rev=760870&r1=760869&r2=760870&view=diff
==============================================================================
---
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
(original)
+++
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Wed Apr 1 12:51:42 2009
@@ -173,9 +173,13 @@
HttpResponse results) throws GadgetException {
try {
String originalUrl = request.getParameter(ProxyBase.URL_PARAM);
- String body = results.getResponseAsString();
- if ("FEED".equals(request.getParameter(CONTENT_TYPE_PARAM))) {
- body = processFeed(originalUrl, request, body);
+ String body = "";
+ if (results.getHttpStatusCode() == 200) {
+ body = results.getResponseAsString();
+
+ if ("FEED".equals(request.getParameter(CONTENT_TYPE_PARAM))) {
+ body = processFeed(originalUrl, request, body);
+ }
}
JSONObject resp = FetchResponseUtils.getResponseAsJson(results, null,
body);